[MPlayer-cvslog] CVS: main/libmpdemux mpeg_hdr.c, 1.11, 1.12 mpeg_hdr.h, 1.4, 1.5

[Dominik 'Rathann' Mierzejewski]

On Tuesday, 19 April 2005 at 23:17, Loren Merritt CVS wrote:
> CVS change done by Loren Merritt CVS
> 
> Update of /cvsroot/mplayer/main/libmpdemux
> In directory mail:/var2/tmp/cvs-serv6110
> 
> Modified Files:
> 	mpeg_hdr.c mpeg_hdr.h 
> Log Message:
> integer overflow when reading fps from h264 vui.
> 
> 
> Index: mpeg_hdr.c
> ===================================================================
> RCS file: /cvsroot/mplayer/main/libmpdemux/mpeg_hdr.c,v
> retrieving revision 1.11
> retrieving revision 1.12
> diff -u -r1.11 -r1.12
> --- mpeg_hdr.c	9 Apr 2005 11:00:00 -0000	1.11
> +++ mpeg_hdr.c	19 Apr 2005 21:17:39 -0000	1.12
> @@ -286,7 +286,7 @@
>      fixed_fps = getbits(buf, n, 1);
>      
>      if(picture->timeinc_unit > 0 && picture->timeinc_resolution > 0)
> -      picture->fps = (picture->timeinc_resolution * 10000) / picture->timeinc_unit;
> +      picture->fps = ((uint64_t)picture->timeinc_resolution * 10000) / picture->timeinc_unit;

100l! Don't commit code you didn't even compile.
mpeg_hdr.c: In function `h264_parse_vui':
mpeg_hdr.c:289: error: `uint64_t' undeclared (first use in this function)
mpeg_hdr.c:289: error: (Each undeclared identifier is reported only once
mpeg_hdr.c:289: error: for each function it appears in.)
mpeg_hdr.c:289: error: syntax error before "picture"

Fixed.

R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"