[MPlayer-cvslog] CVS: main configure, 1.1044, 1.1045 Makefile, 1.329, 1.330

[The Wanderer]

Rich Felker wrote:

> On Sun, Aug 21, 2005 at 10:26:08AM +0200, Michael Niedermayer wrote:
> 
>> Hi
>> 
>> On Sun, Aug 21, 2005 at 06:25:58AM +0200, Diego Biurrun wrote:
>> 
>>> On Sat, Aug 20, 2005 at 09:30:04PM -0400, Rich Felker wrote:

>>> Let's say that it was inspired by that commit, but I'm talking in
>>> general, there are many more examples.  Yes, it will be obvious
>>> to those in the know, but if you look at the output of 'cvs log'
>>> then 10l is not descriptive unless you see the diff as well,
>>> while something like "int/int does not produce a float value"
>>> is...
>> 
>> this is still not good, the commit log should at least contain

>> * low level descrioption / diff summary like (int/int does not
>> produce...)
> 
> IMO when the diff is short someone can be expected to read it..

But the diff is not always available ready to hand - it's there when
reading the CVS-log mailing list, yes, but not when reading the output
of 'cvs log'. For circumstances like that latter, having this kind of
explanation can be helpful.

As to the discussion itself, I'm largely agnostic; on the one hand, I
can agree that descriptive commit messages are a good idea, for the
reason cited, but on the other hand, I have a hard enough time phrasing
my own commit messages as it is. ^_^ Whichever way the decision goes, I
can live with it.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.