[MPlayer-cvslog] CVS: main configure, 1.1044, 1.1045 Makefile, 1.329, 1.330

[Michael Niedermayer]

Hi

On Sun, Aug 21, 2005 at 02:20:04PM +0200, Attila Kinali wrote:
[...]
> +   A commit message should at least contain:
> +   
> +   * A high level description of what the change does (fixes calculation of...).

agree as long as its not too high level, i mean it shouldnt require
knowledeg beyond what is needed to fix a bug
for example, in the fps= int/int case, a description of what user 
vissible effects like av sync / frame droping where nice but it should
not be required


> +   * A low level description, summary of the diff (int/int does not produce...).

agree


> +   * A list of bug numbers, mailinglist archive links together with the
> +     Message-ID's of the mails of the bugs fixed
> +     (fixes bug #23, 
> +     http://www.mplayerhq.hu/pipermail/mplayer-users/2005-August/055157.html,
> +     Message-ID: <43084FB4.2090303 at poczta.onet.pl>).

disagree, too much work


> +   * A description of possible unwanted side effects (might not work in case X).
> +   * A summary of performed tests and benchmarks.

if these are available/known, yes they should be included


> +   * Severity of the bug/change.
> +   * One or more of the tags of:
> +       - cosmetic
> +       - crash-fix
> +       - rounding-fix
> +       - security-fix
> +       - spelling-fix
> +       - indention-fix
> +       - untested
> +       - new-feature
> +       - optimization
> +     marked with the keyword "TAGS:" in the first line of the commit message
> +     (eg "TAGS: new-feature, untested").

ok

i also suggest that we add the following to the cvs commit template
----
severity: critical/serious/normal/minor/enhancement
TAGS: cosmetic, crash-fix, security-fix, spelling-fix, indention-fix, build-fix, untested, new-feature, optimization
CVS: severity levels:
CVS: critical:   possible data loss, arbitrary code execution secholes
CVS: serious:    compile failure, otherwise totally unuseable
CVS: normal:     normal bug fixes
CVS: minor:      a fix which wont be noticed by the average user
CVS: enhancement:no bugfix
CVS: remove the cases which dont apply to this commit from the TAGS and 
CVS: severity lines!
----

[...]
-- 
Michael