[MPlayer-cvslog] CVS: main codec-cfg.c,1.120,1.121

Oded Shimon ods15 at ods15.dyndns.org
Tue Dec 6 19:22:05 CET 2005


On Tue, Dec 06, 2005 at 03:07:43PM +0100, Alexander Strasser wrote:
> Hi Oded,
> 
> Oded Shimon CVS wrote:
> > +int mp_msg_levels[MSGT_MAX];
> > +int mp_msg_level_all = MSGL_STATUS;
> > +int verbose = 0;
> 
>   This brings me back to the question i asked myself, while
> reading your last messages/patches, several times:
>   Why didn't you leave mp_msg_levels in mp_msg.c then added
> mp_msg_level_all there too and declare them extern in mp_msg.h?

When I originally did it, it was for cfg-common.h and naturally I put the 
vars in mplayer.c , then I decided to shift everything to mplayer.c . In 
retrospect, now that I had to add it in mencoder.c and codec-cfg.c (twice), 
it would've made more sense to put it in mp_msg.c ... Should I fix it now?

- ods15




More information about the MPlayer-cvslog mailing list