[MPlayer-cvslog] CVS: main/DOCS/tech slave.txt,1.48,1.49
    The Wanderer 
    inverseparadox at comcast.net
       
    Mon Dec 12 02:31:36 CET 2005
    
    
  
Diego Biurrun wrote:
> On Sun, Dec 11, 2005 at 05:37:38PM -0500, The Wanderer wrote:
> 
>> syncmail at mplayerhq.hu wrote:
>> 
>>> -[brightness|contrast|gamma|hue|saturation] <-100 - 100> [<abs>]
>>> +[brightness|contrast|gamma|hue|saturation] <value> [<abs>]
>>>     Set/adjust video parameters.
>>> +    If abs is not given or zero, modifies parameter by <value>.
>> 
>> This could equally well be read "If abs is not given or is zero" or
>> "If abs is not given or is not zero". It could be fixed either by
>> swapping the two conditions ("is zero or not given") or by adding
>> the verb ("is not given or is zero"). Either works pretty much
>> equally well, and I'm not sure which would be considered the lesser
>> change; any preference?
> 
> Roll the dice and commit :)  If in doubt, I'd probably go for the
> former.
Since I'd already made one change locally before realizing that the
other would work, I'll just commit that.
-- 
       The Wanderer
Warning: Simply because I argue an issue does not mean I agree with any
side of it.
Secrecy is the beginning of tyranny.
    
    
More information about the MPlayer-cvslog
mailing list