[MPlayer-cvslog] CVS: main/libmpcodecs vf_fspp.c,1.8,1.9

[Diego Biurrun]

On Sun, Dec 18, 2005 at 06:12:06PM +0100, Jindrich Makovicka wrote:
> Diego Biurrun wrote:
> >On Sun, Dec 18, 2005 at 05:37:00PM +0100, Jindrich Makovicka wrote:
> >
> >>Diego Biurrun wrote:
> >>
> >>>On Sun, Dec 18, 2005 at 02:35:51PM +0100, Jindrich Makovicka CVS wrote:
> >>>
> >>>>Modified Files:
> >>>>	vf_fspp.c 
> >>>>Log Message:
> >>>>do not postprocess H264
> >>>
> >>>Why?
> >>
> >>I thought the fact it turns the H264 filtered output into blurred sh*t 
> >>and has to be turned off anyway when playing H264 content is a valid 
> >>reason. I can add a "force" flag if you insist.
> >
> >I don't understand what you mean by "has to be turned off anyway".
> >Filters have to be enabled explicitly.  If vf_fspp does not give good
> >results on H.264 material, people will just not use that combination.
> >Why you want to forbid it is beyond me...
> 
> I prefer having PP enabled in the configuration file. This way it's less 
> hassle as I don't have to disable this filter manually each time I play 
> H264.

IMO this is a hack added for your personal convenience that does not
belong in the code...

Why don't you use two different shellscripts with different sets of
options depending on the content you play or something similar?

Diego