[MPlayer-cvslog] CVS: main/libmpcodecs vf_fspp.c,1.8,1.9

[Robert Swain]

Hello,

----- Original Message ----- 
From: "Reimar Döffinger" <Reimar.Doeffinger at stud.uni-karlsruhe.de>
To: "MPlayer CVS changelogs and discussion" <mplayer-cvslog at mplayerhq.hu>
Sent: Monday, December 19, 2005 9:47 AM
Subject: Re: [MPlayer-cvslog] CVS: main/libmpcodecs vf_fspp.c,1.8,1.9


> Hi,
> On Sun, Dec 18, 2005 at 09:33:09PM +0100, Jindrich Makovicka wrote:
>> >Why don't you use two different shellscripts with different sets of
>> >options depending on the content you play or something similar?
>>
>> I am lazy, what else :) And I didn't really expected such a flame over
>> this issue.
>
> Maybe the flame is about that you seem to like to meddle with other
> people's code with out asking first, as according to our CVS policy you
> should? Though I see to become the only one caring about it so whatever...
>

Not to gang up on you Jindrich, and not that I have much stature on this ML, 
but I agree with Diego, Michael, Rich, Reimar... that you've altered the 
functionality of one filter for personal gain and taken it out of line of 
the functionality of the rest of the filters. I do see your point that it 
makes h.264 streams look bad but the user should be the one to decide and 
they should be able to do so within a consistent filter environment. Rich's 
suggestion for conditional scripting is a better solution.

Just my two pence,
Rob