[MPlayer-cvslog] CVS: main/etc codecs.conf,1.393,1.394

[D Richard Felker III]

On Tue, Feb 22, 2005 at 09:05:49PM +0100, Jindrich Makovicka wrote:
> D Richard Felker III wrote:
> >On Tue, Feb 22, 2005 at 08:52:03PM +0100, Reimar Döffinger wrote:
> >
> >>Hi,
> >>
> >>>--- codecs.conf	21 Feb 2005 17:40:46 -0000	1.393
> >>>+++ codecs.conf	22 Feb 2005 19:18:44 -0000	1.394
> >>>@@ -203,7 +203,7 @@
> >>>  format 0xFFFC
> >>>  driver theora
> >>>  dll libtheora
> >>>-  out YV12
> >>>+  out YV12 flip
> >>
> >>Now that a "major" format uses flip... did you test with the gui? I think 
> >>flip still doesn't work correctly with it :-(
> >>See also http://bugzilla.mplayerhq.hu/show_bug.cgi?id=162 .
> 
> Err, I just found that -vf pp still crashes due to negative destination 
> stride, but -vf pp,scale works.
> 
> >IMO flip is deprecated! Negative stride is the correct way to do this.
> >Just fix the broken filters that crash on negative stride.
> 
> I am not sure if -vf pp can be fixed without performance penalty, not 
> mentioning I am not very into studying the postprocessing code with all 
> asm variants :) Another way to fix Theora is to add one more framecopy 
> to vd_theora and use MP_IMAGE_STATIC (it wouldn't be such a big 
> performance hit as Theora is pretty cpu hungry anyway). Actually this 
> was the fix I used before for Theora, and it obviously worked.

This is not at all acceptable in MPlayer. Please, just put it back the
way it was, with negative strides. Negative strides are already used
in MPlayer, so if there are filters that crash with them, those need
to be fixed or just force a separate "copy-to-positive-stride-image"
filter to be loaded before them.

Rich