[MPlayer-cvslog] Re: CVS: main/postproc swscale_template.c, 1.116, 1.117

[Michael Niedermayer]

Hi

On Tuesday 28 June 2005 22:05, Reimar Döffinger wrote:
> Hi,
>
> On Tue, Jun 28, 2005 at 10:23:54PM +0300, Ismail Donmez wrote:
> > On Tuesday 28 June 2005 22:07, Guillaume POIRIER wrote:
> > > > +#define inline inline __attribute__((always_inline))
> > > > +
> > > >  #undef REAL_MOVNTQ
> > > >  #undef MOVNTQ
> > > >  #undef PAVGB
> > >
> > > This fixed the crash on my machine with gcc-3.3. Is it a desirable fix?
> >
> > Looks like libavcodec uses it, from libavcodec/common.h
> >
> > #ifndef always_inline
> > #if defined(__GNUC__) && (__GNUC__ > 3 || __GNUC__ == 3 && __GNUC_MINOR__
> > > 0) #    define always_inline __attribute__((always_inline)) inline
> > #else
> > #    define always_inline inline
> > #endif
> > #endif
>
> unfortunately neither of these will probably fix it really, since I also
> get a crash with gcc 3.4.4 when using mf://*.png (e.g. on the examples
> in incoming/PngBug.tar.gz)
> Changing the "g" restraint to "m" again in swscale_template.c, line 2550
> seems to fix all problems for me, although I don't know why...

what about posting the generated asm code from the crashing function? (with 
gcc -S)

[...]
-- 
Michael