[MPlayer-cvslog] CVS: main/libmpdemux demux_nuv.c,1.12,1.13

Sascha Sommer saschasommer at freenet.de
Wed Jun 29 07:08:14 CEST 2005


Hi,

On Wednesday 29 June 2005 06:56, Rich Felker wrote:
> On Sun, Jun 26, 2005 at 05:15:40PM +0200, Sascha Sommer CVS wrote:
> > CVS change done by Sascha Sommer CVS
> >
> > Update of /cvsroot/mplayer/main/libmpdemux
> > In directory mail:/var2/tmp/cvs-serv22825/libmpdemux
> >
> > Modified Files:
> >  demux_nuv.c
> > Log Message:
> > 10l
>
> for commits like this please explain why it's 10l..
>

I think one should always check if the requested amount of data has really 
been read when using file io functions.
In this case the file was a directory so stream_read failed and valgrind 
complained about the following strncmp comparing uninitialized buffers.

Sascha




More information about the MPlayer-cvslog mailing list