[MPlayer-cvslog] CVS: main/libvo vo_sdl.c,1.118,1.119

[Michael Niedermayer]

Hi

On Tuesday 01 March 2005 12:24, Reimar Döffinger wrote:
> Hi,
>
> On Tue, Mar 01, 2005 at 04:51:50AM +0100, Ivo van Poorten CVS wrote:
> > +    if(sdl_driver) setenv("SDL_VIDEODRIVER", sdl_driver, 1);
> > +    free(sdl_driver);
>
> Most MPlayer code checks if a pointer is null before freeing - but

IMHO a
#define free(x) if(x) free(x)
somewhere would be a better idea, or a mp_free() maybe ...

[...]

-- 
Michael

"nothing is evil in the beginning. Even Sauron was not so." -- Elrond