[MPlayer-cvslog] CVS: main/libmpdemux demux_ogg.c,1.69,1.70

[Joey Parrish]

On Wed, May 04, 2005 at 10:57:32AM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > > > +  demuxer->priv =
> > > >    ogg_d = (ogg_demuxer_t*)calloc(1,sizeof(ogg_demuxer_t));

> > > I haven't tried to compile this yet, but I'm pretty certain that this won't
> > > compile without an initial value and a semicolon.

> > The newline doesn't matter.  It is effectively the same as:
> > demuxer->priv = ogg_d = (ogg_demuxer_t*)calloc(1,sizeof(ogg_demuxer_t));
> > Both demuxer->priv and ogg_d will have the same value.

> You are correct. However, this would've been much more readable without
> the newline.

This is why I think the cosmetic policy is too strict.  People are doing
this kind of thing to avoid "cosmetic" changes.  Readability, especially
as it pertains to the actual code you're altering, should come first.
This is a good example of that.

--Joey

-- 
"There's no blood in your brain?  You're one of the lucky ones." --Chad