[MPlayer-cvslog] CVS: main/libvo vo_directx.c,1.59,1.60

[Joey Parrish]

On Fri, Nov 11, 2005 at 06:12:35PM +0100, Alexander Strasser wrote:
> Joey Parrish CVS wrote:
> > CVS change done by Joey Parrish CVS
> > Modified Files:
> > 	vo_directx.c 
> > Log Message:
> > Intercept maximize event and go into fullscreen mode.
> > 
> > Index: vo_directx.c
> > ===================================================================
> > RCS file: /cvsroot/mplayer/main/libvo/vo_directx.c,v
> > retrieving revision 1.59
> > retrieving revision 1.60
> > diff -u -r1.59 -r1.60
> > --- vo_directx.c	10 Nov 2005 22:25:54 -0000	1.59
> > +++ vo_directx.c	11 Nov 2005 13:22:01 -0000	1.60
> > @@ -914,6 +914,9 @@
> >  				case SC_MONITORPOWER:
> >                  mp_msg(MSGT_VO, MSGL_V ,"<vo_directx><INFO>killing screensaver\n" );
> >                  return 0;                      
> > +				case SC_MAXIMIZE:
> > +					if (!vo_fs) control(VOCTRL_FULLSCREEN, NULL);
> > +                return 0;                      
> >  			}
> >  			break;
> >  		}
> 
>   Is it necesarry? I know that some windows users expect this
> strange behaviour for movie players, but it makes it impossible
> to maximize the window except doing it by hand.
>   At least making it configurable so that normal window handling
> can take place would IMHO be better.
>   Btw IIRC wmp doesn't do it this way, so at least it is not that
> uncommon to not switch to fullscreen when maximize is requested.

I got a number of requests for this feature in private mails, so I
tried it in my packages months ago.  It's not strictly neccessary,
though.  Do you have a suggestion for an option name for this behavior?
Should it be an mplayer option or a vo_directx option?

Any other opinions?

--Joey

-- 
"There's no blood in your brain?  You're one of the lucky ones." --Chad