[MPlayer-cvslog] CVS: main/libvo sub.c,1.78,1.79

[Rich Felker]

On Sun, Oct 23, 2005 at 04:25:58PM +0200, Diego Biurrun CVS wrote:
> CVS change done by Diego Biurrun CVS
> 
> Update of /cvsroot/mplayer/main/libvo
> In directory mail:/var2/tmp/cvs-serv14011/libvo
> 
> Modified Files:
> 	sub.c 
> Log Message:
> The conditions for bottom (2) and top (1) subtitle alignment are reversed.
> patch by Paul TT < paultt == at -- hackerjournal == dot -- it >
> 
> 
> Index: sub.c
> ===================================================================
> RCS file: /cvsroot/mplayer/main/libvo/sub.c,v
> retrieving revision 1.78
> retrieving revision 1.79
> diff -u -r1.78 -r1.79
> --- sub.c	10 Apr 2005 11:54:31 -0000	1.78
> +++ sub.c	23 Oct 2005 14:25:56 -0000	1.79
> @@ -627,7 +627,7 @@
>      }
>      /// vertical alignment
>      h = dys - obj->y;
> -    if (sub_alignment == 2)
> +    if (sub_alignment == 0)
>          obj->y = dys * sub_pos / 100 - h;
>      else if (sub_alignment == 1)
>          obj->y = dys * sub_pos / 100 - h / 2;

Are you sure? IMO this patch is incorrect. The old behavior matches
the man page.

Rich