[MPlayer-cvslog] CVS: main/libmpcodecs ad_faad.c,1.21,1.22

[Rich Felker]

On Fri, Sep 02, 2005 at 10:53:18AM +0200, Attila Kinali wrote:
> On Thu,  1 Sep 2005 17:59:59 +0200 (CEST)
> syncmail at mplayerhq.hu (Attila Kinali CVS) wrote:
> 
> > Modified Files:
> > 	ad_faad.c 
> > Log Message:
> > * really keep track on how many samples were decoded last round (fix 10l)
> > * leave loop if more than 10 faad errors were detected since the last
> >   call of decode_audio
> [...]
> > +  while(len < minlen && last_dec_len > 0 && errors < MAX_FAAD_ERRORS) {
> 
> BTW: I know that this is a very bad way to handle errors as it
> makes it impossible to recover from an error in a broken stream.
> But i could not find a way how to extract from the faad errors
> that the end of a stream has been reached and thus it cannot
> "resync" anymore.

What, does aac have separate I/P frame types?! If not, this is
nonsense, and you can start decoding at any frame.

IMO this sync stuff belongs in a demuxer for unframed 'raw' aac files,
not in the decoder which should only accept whole frames!

Rich