[MPlayer-cvslog] CVS: main configure,1.1053,1.1054

[Ivan Kalvachev]

2005/9/10, Reimar Döffinger CVS <syncmail at mplayerhq.hu>:
> CVS change done by Reimar Döffinger CVS
> 
> Update of /cvsroot/mplayer/main
> In directory mail:/var2/tmp/cvs-serv24272
> 
> Modified Files:
>         configure
> Log Message:
> Make sure _freetype is either yes or no, otherwise fontconfig might be enabled
> even without iconv (and thus freetype) support
> 
> 
> Index: configure
> ===================================================================
> RCS file: /cvsroot/mplayer/main/configure,v
> retrieving revision 1.1053
> retrieving revision 1.1054
> diff -u -r1.1053 -r1.1054
> --- configure   10 Sep 2005 17:03:35 -0000      1.1053
> +++ configure   10 Sep 2005 18:23:40 -0000      1.1054
> @@ -5086,6 +5086,9 @@
>      _def_freetype='#undef HAVE_FREETYPE'
>  fi
>  echores "$_freetype"
> +if test "$_freetype" != yes ; then
> +    _freetype=no
> +fi
> 
>  if test "$_freetype" = no ; then
>      _fontconfig=no
> 

Don't like that fix.
1. it dublicates code. e.g. merging both contitions would do the trick.
2. _option should always be 'yes','no','auto'. The problem here is a
few lines above in this code:

if test "$_iconv" = no ; then
    _freetype="no (iconv support needed)"
fi

This nice message bugs the code under it.
An much cleaner solution would be to have just
_freetype=no
If we want an comment, maybe we should add an new variable _comment
and use it at echores.
I'm writing a patch. Do you want to see it?