[MPlayer-cvslog] CVS: main/libmpcodecs vf_screenshot.c,1.4,1.5

[Reimar Döffinger]

Hi,
On Sun, Sep 11, 2005 at 05:41:10PM +0200, Jindrich Makovicka CVS wrote:
> @@ -209,7 +212,8 @@
>  	if(vf->priv->store_slices) {
>  	    vf->priv->store_slices = 0;
>  	    gen_fname(vf->priv);
> -	    write_png(vf->priv->fname, vf->priv->buffer, vf->priv->dw, vf->priv->dh, vf->priv->stride);
> +	    if (vf->priv->fname[0])
> +		write_png(vf->priv->fname, vf->priv->buffer, vf->priv->dw, vf->priv->dh, vf->priv->stride);
>  	}
>  	return vf_next_put_image(vf,vf->dmpi);
>      }
> @@ -235,8 +239,10 @@
>      if(vf->priv->shot) {
>  	vf->priv->shot=0;
>  	gen_fname(vf->priv);
> -	scale_image(vf->priv);
> -	write_png(vf->priv->fname, vf->priv->buffer, vf->priv->dw, vf->priv->dh, vf->priv->stride);
> +	if (vf->priv->fname[0]) {
> +	    scale_image(vf->priv);
> +	    write_png(vf->priv->fname, vf->priv->buffer, vf->priv->dw, vf->priv->dh, vf->priv->stride);
> +	}

Cosmetics! May I suggest that next time you post your patches to the
list and wait until they are actually working and not completely buggy
before commiting? I'll send a patch shortly that will fix a few things.

Greetings,
Reimar Döffinger