[MPlayer-cvslog] CVS: main/libmpdemux tv.h, 1.31, 1.32 frequencies.h, 1.2, 1.3 frequencies.c, 1.2, 1.3

[Ivan Kalvachev]

2006/4/3, Richard Felker CVS <syncmail at mplayerhq.hu>:
> CVS change done by Richard Felker CVS
>
> Update of /cvsroot/mplayer/main/libmpdemux
> In directory mail:/var2/tmp/cvs-serv14361
>
> Modified Files:
>         tv.h frequencies.h frequencies.c
> Log Message:
> 10l: huge amount of constant crap in data segment
>
> Index: tv.h
> ===================================================================
> RCS file: /cvsroot/mplayer/main/libmpdemux/tv.h,v
> retrieving revision 1.31
> retrieving revision 1.32
> diff -u -r1.31 -r1.32
> --- tv.h        18 Nov 2005 14:39:20 -0000      1.31
> +++ tv.h        3 Apr 2006 06:38:55 -0000       1.32
> @@ -82,7 +82,7 @@
>      /* specific */
>      int                        norm;
>      int                        chanlist;
> -    struct CHANLIST    *chanlist_s;
> +    const struct CHANLIST *chanlist_s;
>      int                        channel;
>  } tvi_handle_t;
>
>
> Index: frequencies.h
> ===================================================================
> RCS file: /cvsroot/mplayer/main/libmpdemux/frequencies.h,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -r1.2 -r1.3
> --- frequencies.h       14 May 2005 20:26:46 -0000      1.2
> +++ frequencies.h       3 Apr 2006 06:38:55 -0000       1.3
> @@ -89,21 +89,21 @@
>  /* --------------------------------------------------------------------- */
>
>  struct CHANLIST {
> -    char *name;
> +    char  name[8];
>      int   freq;
>  };
>
>  struct CHANLISTS {
> -    char             *name;
> -    struct CHANLIST  *list;
> -    int               count;
> +    char                   *name;
> +    const struct CHANLIST  *list;
> +    int                    count;
>  };
>
>  #define CHAN_COUNT(x) (sizeof(x)/sizeof(struct CHANLIST))
>
>  /* --------------------------------------------------------------------- */
>
> -extern struct CHANLISTS   chanlists[];
> +extern const struct CHANLISTS   chanlists[];
>  //extern struct STRTAB chanlist_names[];
>
>  extern int                chantab;
>

I'm against these changes. They make impossible future addition or
runtime configureable channels.
The rest are ok.