[MPlayer-cvslog] CVS: main/libmpdemux tv.h, 1.31, 1.32 frequencies.h, 1.2, 1.3 frequencies.c, 1.2, 1.3

Ivan Kalvachev ikalvachev at gmail.com
Tue Apr 4 08:58:36 CEST 2006


2006/4/4, Rich Felker <dalias at aerifal.cx>:
> On Mon, Apr 03, 2006 at 10:14:26AM +0200, Jindrich Makovicka wrote:
> > On 4/3/06, Ivan Kalvachev <ikalvachev at gmail.com> wrote:
> > > I'm against these changes. They make impossible future addition or
> > > runtime configureable channels.
> > > The rest are ok.
> >
> > Size of these arrays is fixed at the compile time, so adding new
> > entries would be difficult even without const.
>
> Indeed. Modifying these arrays is NOT the way to add channel lists at
> runtime.

Who's talking about arrays? I'm talking about struct definitions.
Are you blind or?

IMHO removing const there would not change the way compiler treats the
const data...
I just think this is overkill to have const on both definitions and
places. For sure const stuct definition will make IMPOSSIBLE to add
user defined channels. (And will be removed when this happens).




More information about the MPlayer-cvslog mailing list