[MPlayer-cvslog] CVS: main/libmpcodecs vf_noise.c,1.17,1.18

[Rich Felker]

On Tue, Apr 04, 2006 at 01:29:46PM +0200, Alex Beregszaszi wrote:
> Hi,
> 
> > > > -static int nonTempRandShift[MAX_RES]= {-1};
> > > > +static int nonTempRandShift_init;
> > > 
> > > For case of safety set this to zero. I know in theory everything is
> > > perfect...
> > 
> > No. All uninitialized data is zero. This is guaranteed by C and true
> > on every single implementation. If you don't know C that's your
> > problem. Explicit initialization just adds 4 bytes to the data segment
> > for no reason.
> 
> HAHAHAHA
> 
> Rich, you are getting more crazy with every day. Do you think that 4
> bytes hurt? MPlayer is such a bloatware that even your size reduction
> patches cant help in that matter. Better design libavmunge instead
> trolling. </trolling>

No, it doesn't matter either way, but it's stupid to do the
inefficient way just because you don't know C.

Rich