[MPlayer-cvslog] CVS: main m_config.c, 1.15, 1.16 m_config.h, 1.7, 1.8 m_option.c, 1.49, 1.50 m_option.h, 1.14, 1.15 m_property.c, 1.3, 1.4 m_property.h, 1.3, 1.4 m_struct.c, 1.4, 1.5 m_struct.h, 1.3, 1.4

Alban Bedel albeu at free.fr
Tue Apr 25 21:14:57 CEST 2006

On Tue, 25 Apr 2006 19:03:30 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> > -// Presets are mean to be used with options struct

That will be hard to fix now :) Otherwise i fixed most of the rest.
> Albeu, come on, you haven't used *a single* third person singular s in
> that much text.  You can do better than that!

Sure i can, but generaly only for a short period of time. My brain simply
have difficulties including rules that make no sense (as it just fuck the
branch prediction ;). And most of the rules in human language are just that,
old useless crap that is just there bcs it was already there before :(

> Before I sound too negative: It's excellent that you sat down and
> documented all this code, three cheers :-)

Thanks :) Now it's my turn to complain ;) Next time could you keep the diff
headers ? That would make things easier to read.
If you could (at least sometimes) just commit the fix yourself that would
also be nice. For you it is probably just trivial to do, where i often
need a bit of thinking to find and fix the mistakes you pointed out.


More information about the MPlayer-cvslog mailing list