[MPlayer-cvslog] CVS: main cfg-common.h, 1.161, 1.162 cfg-mencoder.h, 1.107, 1.108 cfg-mplayer.h, 1.263, 1.264 configure, 1.1179, 1.1180 edl.c, 1.7, 1.8 mencoder.c, 1.352, 1.353 mplayer.c, 1.947, 1.948

Oded Shimon ods15 at ods15.dyndns.org
Thu Apr 27 15:06:13 CEST 2006

On Thu, Apr 27, 2006 at 03:03:29PM +0200, Ivo wrote:
> On Thursday 27 April 2006 14:40, Uoti Urpala CVS wrote:
> > Log Message:
> > Make EDL compilation unconditional
> Why?
> Maybe I missed the discussion somewhere, but I like the fact that a lot of 
> functionality of MPlayer/MEncoder can be disabled/enabled when it is needed 
> or not.

Uhh, it's just absoloutely nasty ifdefs completely obfuscating the code at 
absoloutely no gain, the total edl code is ~5kb (probably less), 
certainely no size or performance reason to disable it. The only thing 
which should be allowed to be disabled by ifdefs is entire bloated modules 
which have little claws in other code (libmenu, though it does have a bit 
too many claws), things with external dependencies, or affects 
performance. edl falls under none of these.

BTW, thanks Uoti for doing this, been meaning to do it myself but was too 

- ods15

More information about the MPlayer-cvslog mailing list