[MPlayer-cvslog] CVS: main cfg-common.h, 1.161, 1.162 cfg-mencoder.h, 1.107, 1.108 cfg-mplayer.h, 1.263, 1.264 configure, 1.1179, 1.1180 edl.c, 1.7, 1.8 mencoder.c, 1.352, 1.353 mplayer.c, 1.947, 1.948

[Corey Hickey]

Reynaldo H. Verdejo Pinochet wrote:
> On Thu, Apr 27, 2006 at 06:12:23PM +0200, Reimar Doeffinger wrote:
>> Hi,
>> On Thu, Apr 27, 2006 at 03:03:29PM +0200, Ivo wrote:
>>> On Thursday 27 April 2006 14:40, Uoti Urpala CVS wrote:
>>>> Log Message:
>>>> Make EDL compilation unconditional
>>> Why?
>>>
>>> Maybe I missed the discussion somewhere, but I like the fact that a lot of 
>>> functionality of MPlayer/MEncoder can be disabled/enabled when it is needed 
>>> or not.
>> While I agree with the change in principle, such changes are to be
>> discussed before.
>> At least I don't think Uoti is mentioned as maintainer for all the code
>> he changed...
>>
> 
> Humm, Im sure he meant well, we discussed this change with Oded on irc
> lastnight/this morining, maybe he read it and wanted to spare us some work,
> other than that I do think too that having edl ifdefed is nonsence, it
> is ifdefed only because _some time ago_ it was supossed to be an
> *experimental* feature and neither oded or i cared enough to unifdef it
> earlier. Dont get me wrong, I know he may have rushed the things a
> little, so Uoti, next time, carefully read trhoug the MAINTAINERS file
> and sent a patch to dev-eng, im sure you know how it works ;) other
> than that, thanks for your time/work.

By the way, to add to that:
It's usually customary to send a patch to -dev-eng and threaten to 
commit if nobody says no. Allow a length of time appropriate to how 
controversial or intrusive you expect the patch to be; usually 1-3 days 
is sufficient. Of course, if a maintainer of that part of code says so 
in the intervening time, you can apply it before that time is up.

-Corey