[MPlayer-cvslog] CVS: main mplayer.c,1.948,1.949

Oded Shimon ods15 at ods15.dyndns.org
Fri Apr 28 19:22:47 CEST 2006

On Fri, Apr 28, 2006 at 08:19:59PM +0300, Uoti Urpala wrote:
> On Fri, 2006-04-28 at 12:53 -0400, Rich Felker wrote:
> > On Thu, Apr 27, 2006 at 03:16:43PM +0200, Uoti Urpala CVS wrote:
> > > Remove useless "#if 0" blocks
> > 
> > Commits like this should definitely be discussed first, unless you're
> > the maintainer of the file in question!!
> Those blocks were av sync related, nobody else is working on that code,
> I know they were broken/useless, and there was no chance the commit
> would break anything. "Having a discussion" about whether to remove such
> blocks is just silly.

Still, at least send a patch to dev-eng with thread to commit, wait at 
leat a day, and then commit.

- ods15

More information about the MPlayer-cvslog mailing list