[MPlayer-cvslog] r19341 - in trunk/stream: Makefile asf_mmst_streaming.c asf_streaming.c network.c network.h pnm.c stream_ftp.c stream_netstream.c stream_rtsp.c stream_vstream.c tcp.c tcp.h

[Michael Niedermayer]

Hi

On Sun, Aug 06, 2006 at 10:20:09PM +0200, Diego Biurrun wrote:
[...]
> > > > > > policy said not to copy or move files by remove and add but to ask arpi/root
> > > > > > to do it IIRC
> > > > > > surely it should mention svn cp/mv now but its not like it wasnt clear about
> > > > > > what wasnt allowed
> > > > > 
> > > > > I think your memory needs a quick freshup:
> > > > > 
> > > > >   8. Renaming/moving files or contents of files:
> > > > > 
> > > > >     svn move <source> <destination>
> > > > >     svn commit <source> <destination>
> > > > > 
> > > > >     Do not move or rename files before discussing it on the
> > > > >     mplayer-dev-eng mailing list first!
> > > > > 
> > > > >     Don't do a lot of cut'n'paste from one file to another without a
> > > > >     very good reason and discuss it on the mplayer-dev-eng mailing
> > > > >     list first. It will make those changes hard to trace.
> > > > > 
> > > > >     Such actions are useless and treated as cosmetics in 99% of cases,
> > > > >     so try to avoid them.
> > > > > 
> > > > > So maybe this could have been discussed a bit more, but it surely was
> > > > > not forbidden.  
> > > > 
> > > > r18708 said:
> > > > ------
> > > > 8. Renaming/moving files or content of files, removing empty directories:
> > > > 
> > > >   You CANNOT do that. Ask the CVS server admin to do it!
> > > >   Do NOT remove & readd a file - it will kill the changelog!!!!
> > > > ...
> > > > ------
> > > > that IMO means: no you cannot move the content of a file
> > > > 
> > > > did i miss the disscussion of the policy change?
> > > 
> > > That's not a policy change IMO, Subversion preserves history so you
> > > *can* rename files now without losing history and the rest of the
> > > paragraph is unchanged.
> > 
> > well i disagree, the new text is less strict
> 
> It's a matter of interpretation.  I maintain that it's an editorial and
> not a substantial change.  The problem with CVS was that sometimes devs
> would remove and readd files, killing the history in the process.  Many
> were used to it since CVS simply has no concept of renames so it was a
> (sad) fact of life for many.  The text said "cannot", not "must not"...

cannot = admin will reverse it ;)


> 
> > and the whole cvs->svn policy chnages change it significnatly,
> 
> Ivo volunteered to rewrite the guide, I reviewed his changes, there were
> patches and discussion on -dev-eng and -cvslog.  IMO that is more than
> plenty occasion to speak up.

ok, that makes me guilty for being lazy, not reading the realated mails
carefully and consequently not complaining earlier


> 
> I've just looked at the changes again, I really don't see any
> significant changes.  We disagree about the interpretation of the
> renaming issue, but that only shows that it was ambiguous to begin
> with...
> 
> > and anyway if its ok to
> > change the policy like that without disscussions then the policy is
> > useless and can be removed as it does not reflect the oppinion of the
> > majority of the developers but just the oppinion of one single person
> > and maybe not even that as several people can change it at will by
> > claiming it doesnt change its meaning (of course they do belive this
> > and have no bad intentions, but other developers might disagree ...)
> > 
> > so IMO EVERY commit to the policy should be posted as patch to dev-eng
> > and should receive at least more "ok" then "not ok" replies, that also
> > implies at least one "ok" 
> 
> IMO editorial changes are OK, substantial changes should be discussed on
> dev-eng.

fully agree but the question if something is editorial must be disscussed
on dev-eng then, this thread proofs that people can disagree about if
something is editorial or not

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is