[MPlayer-cvslog] r19188 - trunk/mplayer.c

[Diego Biurrun]

On Sun, Aug 13, 2006 at 08:36:21PM +0300, Oded Shimon wrote:
> On Sun, Aug 13, 2006 at 11:12:04AM +0200, Diego Biurrun wrote:
> > On Fri, Jul 28, 2006 at 09:15:26PM +0200, Reimar Döffinger wrote:
> > > On Thu, Jul 27, 2006 at 01:54:06AM +0200, Diego Biurrun wrote:
> > > > On Wed, Jul 26, 2006 at 11:50:12PM +0200, Michael Niedermayer wrote:
> > > > > replace all tabs by spaces, add a "marker" at the top like //forbid tabs
> > > > > and add a check in the precommit script so that files with "//forbid tabs"
> > > > > at the top may not contain tabs ....
> > > > > just IMHO of course ...
> > > > 
> > > > I'm all for it ;)
> > > 
> > > I'd like such a pre-commit script feature (though a separate file list
> > > would be okay for me, too).
> > > Helps to avoid slipping tabs in from patches from other people or
> > > created on a different PC.
> > 
> > So given that three active developers agree that such a thing is
> > desirable, is it time to discuss some sort of style guidelines?
> 
> For what its worth, I'm generally against spaces used as indentation, 
> which is why I dislike this, but I value consistency more... Since this 
> script would only be activated with the '// forbid tabs', I'm not going to 
> scream and shout against this, but I'm not exactly for it... :(
> 
> Then again, I'm not really a (recently) active developer anyway... :)

I do value the fact that you seem to be willing to compromise, that does
not seem to be a very common trait around here...

Diego