[MPlayer-cvslog] r19497 - in trunk: input/input.c input/input.h libmenu/menu_filesel.c mplayer.c

[Benjamin Zores]

On Thu, 24 Aug 2006 16:48:04 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> On Wed, Aug 23, 2006 at 12:20:54PM +0200, Reimar Döffinger wrote:
> > On Tue, Aug 22, 2006 at 11:02:20PM +0200, Benjamin Zores wrote:
> > > Does it has to be documented somewhere ?
> > > I don't really see anything about libmenu grammar (except in /etc/menu.conf as a sample).
> > 
> > Well, unless you'd be ready to expand this:
> > http://www.mplayerhq.hu/DOCS/HTML/en/subosd.html#osdmenu to something
> > useable, IMHO expand /etc/menu.conf to contain examples of the features
> > you add.
> 
> Agreed.  Having a well-commented example configuration file goes a long
> way in making these things usable.

Ok, i'll update etc/menu.conf when all of geexbox libmenu patches will have been merged.
By this way, I have another patch that shows file properties and metadata in OSD menu.
But for that, i need to get access to sh_audio and sh_video which are defined as static in mplayer.c.

What's the best way to handle this ?
1. declare this vars as non static.
2. add functions in mplayer.c such as get_sh_video(), get_sh_audio() to return the requested pointers.

Ben


-- 
"My life, and by extension everyone else's is meaningless."
Bender, Futurama