[MPlayer-cvslog] r21600 - trunk/libvo/vo_x11.c

[Reimar Döffinger]

Hello,
On Wed, Dec 13, 2006 at 01:55:25PM -0500, Rich Felker wrote:
> On Tue, Dec 12, 2006 at 07:43:11PM +0100, reimar wrote:
> > Use XCreateImage instead of XGetImage, this is not only more correct and
> > similar to the SHM case, it also eliminates the massive startup delay over
> > ssh (at least when you have a tiny upstream).
> 
> According to my reading of the Xlib docs, it's legal (and preferable)
> to just setup the XImage struct yourself rather than obtaining it from
> XCreateImage. This way you have more control and you don't have to
> worry about nasty issues of Xlib trying to free your buffer when you
> destroy the image (because it never has to be destroyed).

Well, maybe, but then I would have to get all the information of what
image format the server uses from the Visual somehow... I doubt that
would be much nicer.

Greetings,
Reimar Döffinger