[MPlayer-cvslog] r21631 - in trunk/libass: ass_font.c ass_fontconfig.c

[Reimar Döffinger]

Hello,
On Sat, Dec 16, 2006 at 10:56:50PM +0300, Evgeniy Stepanov wrote:
> On Saturday 16 December 2006 22:23, Dominik 'Rathann' Mierzejewski wrote:
> > On Saturday, 16 December 2006 at 20:19, eugeni wrote:
> > > Author: eugeni
> > > Date: Sat Dec 16 20:19:27 2006
> > > New Revision: 21631
> > >
> > > Modified:
> > >    trunk/libass/ass_font.c
> > >    trunk/libass/ass_fontconfig.c
> > >
> > > Log:
> > > Avoid "pointer targets differ in signedness" warnings.
> >
> > Is it really OK to just cast the warning away? Maybe you should change the
> > data type of the variable instead.
> 
> This data comes from strdup(), which returns char*, and is passed to 
> FcFreeTypeQueryFace(), which requires unsigned char*. It has to be typecasted 
> somewhere.

Well, I find that warning stupid anyway since it is bogus in 90% of
cases and only hides the relevant warnings, no that gcc only warns when
pointers passed to functions have different signedness, it does not warn
when you do assignment AFAIK, so it might be possible in this case
without both warning and cast *g*

Greetings,
Reimar Döffinger