[MPlayer-cvslog] r21631 - in trunk/libass: ass_font.c ass_fontconfig.c

Evgeniy Stepanov eugeni.stepanov at gmail.com
Sun Dec 17 11:26:20 CET 2006

On Sunday 17 December 2006 13:05, Rich Felker wrote:
> > > > Log:
> > > > Avoid "pointer targets differ in signedness" warnings.
> > >
> > > Is it really OK to just cast the warning away? Maybe you should change
> > > the data type of the variable instead.
> >
> > This data comes from strdup(), which returns char*, and is passed to
> > FcFreeTypeQueryFace(), which requires unsigned char*. It has to be
> > typecasted somewhere.
> No, the compiler needs to be fixed not to generate such idiotic
> warnings. Please don't obfuscate the code with ugly explicit casts to
> shut the compiler up; instead just change the warning options so that
> this stupid warning (which never indicates an error since signedness
> is a property of arithmetic operations and not of data itself!!) goes away.

Looks like a good idea. The attached patch does exactly that, reducing 
mplayer.c compilation output by 101 lines :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1.patch
Type: text/x-diff
Size: 411 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20061217/a700814f/attachment.patch>

More information about the MPlayer-cvslog mailing list