[MPlayer-cvslog] r21666 - trunk/libmpdemux/demux_audio.c

[Rich Felker]

On Tue, Dec 19, 2006 at 06:09:48PM +0100, Reimar Döffinger wrote:
> > case, a file should always be detected as mp3 when there is an id2v3
> > header at the beginning immediately followed by a valid string of mp3
> > headers, or when the mp3 headers start at the beginning of the file..
> 
> That does not work because there are too many files where the first
> headers are broken.
> A reduced value if such a code is found very soon in the file could be
> considered though.

I never said anything about rejecting files that don't start
immediately with valid mp3 header, just that files that do start with
mp3 header should always be accepted.

> > And yes if this will misdetect other files then the mp3 detection
> > needs to be moved later in the sequence, but not crippled like this!
> 
> All demuxers can misdetect with format like MXF that allow random crap
> at the start of the file, so should we now try to put all last? Seems
> difficult to do...
> And moving it below lavf is pointless, then we can just rm it.
> How about a patch with a proper solution instead of just stating the
> obvious?

:)
Eventually removing all but lavf would be nice...

Rich