[MPlayer-cvslog] CVS: main/postproc swscale.c,1.163,1.164

Dominik Mierzejewski CVS syncmail at mplayerhq.hu
Thu Feb 9 15:08:05 CET 2006

CVS change done by Dominik Mierzejewski CVS

Update of /cvsroot/mplayer/main/postproc
In directory mail:/var2/tmp/cvs-serv31671/postproc

Modified Files:
Log Message:
Patch by Stefan Huehner / stefan % huehner ! org \

patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.

Comments about a similar patch applied to ffmpeg:

That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter

Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- Måns Rullgård

Index: swscale.c
RCS file: /cvsroot/mplayer/main/postproc/swscale.c,v
retrieving revision 1.163
retrieving revision 1.164
diff -u -r1.163 -r1.164
--- swscale.c	8 Feb 2006 08:20:40 -0000	1.163
+++ swscale.c	9 Feb 2006 14:08:02 -0000	1.164
@@ -1375,7 +1375,7 @@
 #endif // ARCH_X86 || ARCH_X86_64
-static void globalInit(){
+static void globalInit(void){
     // generating tables:
     int i;
     for(i=0; i<768; i++){

More information about the MPlayer-cvslog mailing list