[MPlayer-cvslog] CVS: main/liba52 bitstream.c,1.3,1.4

[Dominik Mierzejewski CVS]

CVS change done by Dominik Mierzejewski CVS

Update of /cvsroot/mplayer/main/liba52
In directory mail:/var2/tmp/cvs-serv31671/liba52

Modified Files:
	bitstream.c 
Log Message:
Patch by Stefan Huehner / stefan % huehner ! org \

patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.

Comments about a similar patch applied to ffmpeg:

That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter

Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- Måns Rullgård



Index: bitstream.c
===================================================================
RCS file: /cvsroot/mplayer/main/liba52/bitstream.c,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- bitstream.c	22 Mar 2005 23:27:18 -0000	1.3
+++ bitstream.c	9 Feb 2006 14:07:53 -0000	1.4
@@ -59,7 +59,7 @@
 }
 
 static inline void
-bitstream_fill_current()
+bitstream_fill_current(void)
 {
     uint32_t tmp;