[MPlayer-cvslog] CVS: main/libmpdemux/realrtsp asmrp.c,1.2,1.3

Dominik Mierzejewski CVS syncmail at mplayerhq.hu
Thu Feb 9 15:08:30 CET 2006

CVS change done by Dominik Mierzejewski CVS

Update of /cvsroot/mplayer/main/libmpdemux/realrtsp
In directory mail:/var2/tmp/cvs-serv31671/libmpdemux/realrtsp

Modified Files:
Log Message:
Patch by Stefan Huehner / stefan % huehner ! org \

patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.

Comments about a similar patch applied to ffmpeg:

That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter

Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- Måns Rullgård

Index: asmrp.c
RCS file: /cvsroot/mplayer/main/libmpdemux/realrtsp/asmrp.c,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- asmrp.c	30 Aug 2004 20:17:31 -0000	1.2
+++ asmrp.c	9 Feb 2006 14:07:57 -0000	1.3
@@ -95,7 +95,7 @@
 } asmrp_t;
-static asmrp_t *asmrp_new () {
+static asmrp_t *asmrp_new (void) {
   asmrp_t *p;

More information about the MPlayer-cvslog mailing list