[MPlayer-cvslog] CVS: main/libmpeg2 motion_comp_mmx.c,1.7,1.8

Dominik Mierzejewski CVS syncmail at mplayerhq.hu
Thu Feb 9 15:08:31 CET 2006

CVS change done by Dominik Mierzejewski CVS

Update of /cvsroot/mplayer/main/libmpeg2
In directory mail:/var2/tmp/cvs-serv31671/libmpeg2

Modified Files:
Log Message:
Patch by Stefan Huehner / stefan % huehner ! org \

patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.

Comments about a similar patch applied to ffmpeg:

That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter

Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- Måns Rullgård

Index: motion_comp_mmx.c
RCS file: /cvsroot/mplayer/main/libmpeg2/motion_comp_mmx.c,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- motion_comp_mmx.c	19 Feb 2005 02:32:12 -0000	1.7
+++ motion_comp_mmx.c	9 Feb 2006 14:07:58 -0000	1.8
@@ -67,7 +67,7 @@
  * unrolling will help
-static inline void mmx_zero_reg ()
+static inline void mmx_zero_reg (void)
     /* load 0 into mm0 */
     pxor_r2r (mm0, mm0);

More information about the MPlayer-cvslog mailing list