[MPlayer-cvslog] CVS: main ChangeLog,1.287,1.288

[Reimar Döffinger]

Hi,
On Mon, Feb 13, 2006 at 12:15:26PM +0100, Clemens Ladisch CVS wrote:
> This patch removes mmap support because it doesn't have any benefit.
> 
> Directly accessing the sample buffer makes sense only when the samples
> can be constructed in-place.  When the samples are just copied from
> another buffer (as is the case with libao2 drivers), the code to copy
> those samples is just a reimplementation of snd_pcm_writei(), so we
> could as well use that function.
> 
> Besides, the current mmap code does not work except in the most simple
> cases: it claims to support non-interleaved and complex sample formats,
> but treats them the same as interleaved formats and writes to the wrong
> memory location.

I appreciate your motivation, but IMHO keep cvs log messages to below 5
lines (try reading the output of cvs log with multiple such messages to
see the problem).
If you think it needs further explanation, discuss it on -dev-eng and if
you find it really important add the Message ID/whatever of that thread
to the message or in the code (whatever is more appropriate).
Hmmm... Maybe we could put this into cvs-howto.txt?

Greetings,
Reimar Döffinger