[MPlayer-cvslog] CVS: main/etc example.conf,1.68,1.69

Dominik 'Rathann' Mierzejewski dominik at rangers.eu.org
Wed Jan 18 20:47:51 CET 2006


On Wednesday, 18 January 2006 at 16:24, Ivan Kalvachev wrote:
> 2006/1/18, Michael Niedermayer <michaelni at gmx.at>:
> > Hi
> >
> > On Wed, Jan 18, 2006 at 02:20:59PM +0200, Ivan Kalvachev wrote:
> > > What the hell are you doing?
> > > You have 4 commits in a row for a same file and you make 2 times
> > > cosmetic changes and 2 times clarify same things. All of them for less
> > > than hour?
> > >
> > > Are you going to commit contest or something?
> >
> > diego is just spliting unrelated things, like it should be done
> > if you dont like it, dont read it, unsubscribe or fork ...
> >
> 
> Thank you for the support.
> 
> Cosmetic changes are done last after function changes to minimize the
> trackback polution.
> You simply flooded it. And made cosmetic twice. My guess is that you
> haven't finished editing it before you start commiting.
> 
> Here is what catched by eye, and i don't think these are unreleated.

Yes, they are. Granted, they touch the same area, but we've agreed
that cosmetics should be committed separately, haven't we?

[...]
> Whatever... man cannot put a joke anymore...

That didn't look like a joke to me either. Putting a smiley there would've
made some difference, I guess.

Regards,
R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"




More information about the MPlayer-cvslog mailing list