[MPlayer-cvslog] CVS: main m_config.c, 1.11, 1.12 m_config.h, 1.6, 1.7 parser-cfg.c, 1.7, 1.8

[The Wanderer]

Diego Biurrun wrote:

> On Tue, Jan 24, 2006 at 12:16:16PM +0100, Alban Bedel CVS wrote:
> 
>>Modified Files:
>>	m_config.c m_config.h parser-cfg.c 
>>Log Message:
>>Profiles support.

>>+static int
>>+parse_profile(m_option_t* opt,char *name, char *param, void* dst, int src) {
>>+  m_config_t* config = opt->priv;
>>+  char** list = NULL;
>>+  int i,r;
>>+  if(param && !strcmp(param,"help")) {
>>+    m_profile_t* p;
>>+    if(!config->profiles) {
>>+      mp_msg(MSGT_FIXME, MSGL_FIXME, "No profile have been defined.\n");

Inconsistent plurality - you need to say either "profile has" or
"profiles have".

>>+      return M_OPT_EXIT-1;
>>+    }
>>+    mp_msg(MSGT_FIXME, MSGL_FIXME, "Available profiles:\n");
>>+    for(p = config->profiles ; p ; p = p->next)
>>+      mp_msg(MSGT_FIXME, MSGL_FIXME, "\t%s\t%s\n",p->name,
>>+	     p->desc ? p->desc : "");
>>+    mp_msg(MSGT_FIXME, MSGL_FIXME, "\n");
> 
> Please replace the MSGT_FIXME and MSGL_FIXME with something sane.
> All of them while you're at it ;)

Definitely. MSG?_FIXME are intended *solely* for use when someone
replacing printfs in a part of the code with which they are unfamiliar
doesn't know what MSG? would be correct. Committing them at any other
time should be considered an error, IMO.

You might add the message strings (intended to be printed at a level
less verbose than -v) to the translatables file while you're at it.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.