[MPlayer-cvslog] r18896 - trunk/edl.c

[Dominik 'Rathann' Mierzejewski]

On Tuesday, 04 July 2006 at 14:40, Reimar Doeffinger wrote:
> Hello,
> On Tue, Jul 04, 2006 at 04:56:25AM -0400, Reynaldo H. Verdejo Pinochet wrote:
> > It started just as a 'denest', then i discovered the bugs and i
> > solved them, hope you can understand.
> 
> Not really. It was discussed so often that you should know all the
> arguments, not to mention that it simply is CVS policy.
> If only 20 people spent 10 seconds trying to figure out what this patch
> is supposed to do, more time is wasted than it would have cost you to
> simply do
> svn diff --diff-cmd diff -x "-uwBE"
> and maybe some hand-editing to get an at least somewhat clean patch.
> To spare others the effort, here's the output (without any
> hand-editing, which would have recognized that last "if (edl_records)" 
> change as cosmetics, too).

Agree, revert and recommit in two steps.

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://rpm.greysector.net/mplayer/
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan