[MPlayer-cvslog] r19148 - in trunk/libswscale: rgb2rgb.c swscale-example.c swscale.c swscale.h swscale_internal.h yuv2rgb.c yuv2rgb_altivec.c

[Reimar Doeffinger]

Hello,
On Thu, Jul 20, 2006 at 02:13:57PM +0200, lucabe wrote:
>  #define MIN(a,b) ((a) > (b) ? (b) : (a))
>  #define MAX(a,b) ((a) < (b) ? (b) : (a))

IMHO replace with FFMIN/FFMAX while we're at cleaning up stuff.

> -	free(filter); filter=NULL;
> +	av_free(filter); filter=NULL;
>  
>  	/* try to reduce the filter-size (step1 find size and shift left) */
>  	// Assume its near normalized (*0.5 or *2.0 is ok but * 0.001 is not)
> @@ -1130,7 +1146,7 @@
>  			else		   filter[i*filterSize + j]= filter2[i*filter2Size + j];
>  		}
>  	}
> -	free(filter2); filter2=NULL;
> +	av_free(filter2); filter2=NULL;

av_freep I think would be more suitable here.

> @@ -1199,7 +1215,7 @@
>  		(*outFilter)[j + i]= (*outFilter)[j + i - (*outFilterSize)];
>  	}
>  
> -	free(filter);
> +	av_free(filter);

Is it intentional that there's no filter=NULL here? I didn't read the
code, only the patch.

Greetings,
Reimar Doeffinger