[MPlayer-cvslog] r19188 - trunk/mplayer.c

[Reimar Döffinger]

Hello,

[mostly irrelevant since you fixed it yourself]

On Wed, Jul 26, 2006 at 11:47:44PM +0300, Uoti Urpala wrote:
> > Well, for me it makes not a big change in readability, so I didn't
> > bother. And since the indentation is a mixture of tabs and spaces (first
> > level is 4 spaces, second is one tab), I don't really know how I am
> > supposed to fix it.
> 
> 4 spaces per indent level, spaces to a tab stop replaced with a tab in
> this case (it was written in the default xemacs indent mode). Is a tab
> for 8 spaces that surprising? If you want to use spaces only that's OK
> too.

Well, when I use tabs I usually have set tabwidth set to 2 or 4, which
of course makes this look rather horrible. Luckily I haven't set it on
my main devel machine (don't use tabs anymore these days), so it looked
alright but I was nevertheless wondering what the system was supposed to
be for the next level - 12 spaces, 4 spaces + tab, tab + 4 spaces - each
looking in a different crappy way depending on tabwidth.

> > Though I can send patches for such stuff (at least when it concerns your
> > code) and you can fix it all in the way you like it :-).
> 
> I don't see how sending patches instead of committing would help
> anything, except possibly reduce the total number of commits.

Well, then you can either apply it the way you want it or you can tell me how
you want the indentation.

Greetings,
Reimar Döffinger