[MPlayer-cvslog] r19182 - trunk/TOOLS/mphelp_check.py

[Uoti Urpala]

On Sat, 2006-07-29 at 00:41 -0400, Rich Felker wrote:
> > +    r = re.compile('%[^diouxXeEfFgGaAcspn%]*[diouxXeEfFgGaAcspn%]')
> 
> I haven't looked at the code, but this regex looks a bit odd.. Why not
> %([0-9][$])?['-+ #0]*[0-9]*[.]?[0-9]*(hh?|ll?|j|z|t|L)?[diouxXeEfFgGaAcspn%]
> or something like that? :)
> 
> Of course I suppose the current one will work too as long as all
> format strings are valid... :)

It's supposed to match the parts of the strings that need to match each
other. If a format string has invalid syntax it's at least not worse to
check that the translations match than to ignore the format completely.