[MPlayer-cvslog] r18718 - in trunk/libvo: vo_x11.c vo_xmga.c vo_xv.c vo_xvidix.c vo_xvmc.c x11_common.c

[The Wanderer]

(Weird... I seem to recall seeing this be discussed on one of the
mailing lists, but a quick scan isn't finding where...)

reimar wrote:

> Author: reimar
> Date: Thu Jun 15 10:00:37 2006
> New Revision: 18718
> 
> Modified:
>    trunk/libvo/vo_x11.c
>    trunk/libvo/vo_xmga.c
>    trunk/libvo/vo_xv.c
>    trunk/libvo/vo_xvidix.c
>    trunk/libvo/vo_xvmc.c
>    trunk/libvo/x11_common.c
> 
> Log:
> Fix window position when changing videos while in fullscreen and for
> window managers that modify position on Map. Oked by Alexander Strasser.

I run Enlightenment (E16), using -vo xv, and this commit broke
window-location memory for me. With r18717, the non-fullscreen window
appears in the location where I expect it to (i.e., not covering up the
various other windows I invariably want to interact with when watching a
video in something other than fullscreen), but with r18718 and later it
appears in the center of the screen - fiddling with the window manager's
Remember setting for that window does nothing.

The same behaviour occurs with x11, gl, and gl2; similar but not
identical behaviour (the window appears at the side of the screen rather
than in the center) occurs with aa and caca; the behaviour does *not*
occur with sdl, although there the window appears in the same default
location as the other two SDL-video-output programs I often run. VIDIX
doesn't work for me, and I don't have MGA that I know of, so I can't
test with those.

I'm not 100% positive this counts as a bug (it's possible that I could,
via much experimentation, figure out the correct values to pass to the
-geometry option in order to get the window to sit where I want it to),
but it is for me undesirable behaviour, so I thought I'd make note of
it.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.