[MPlayer-cvslog] CVS: main/libmpdemux demux_mpg.c,1.73,1.74

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Wed Mar 8 17:01:10 CET 2006


Hi,
On Wed, Mar 08, 2006 at 04:37:15PM +0100, Guillaume POIRIER wrote:
> On 3/8/06, Reimar Döffinger CVS <syncmail at mplayerhq.hu> wrote:
> > @@ -559,7 +559,10 @@
> >    pack = new_demux_packet(STREAM_BUFFER_SIZE);
> >    len = stream_read(demux->stream, pack->buffer, STREAM_BUFFER_SIZE);
> >    if (len <= 0)
> > +  {
> > +    free_demux_packet(pack);
> >      return 0;
> > +  }
> >    {
> >      register uint32_t state = (uint32_t)demux->priv;
> >      register int pos = -len;
> 
> Correct me if I'm wrong, but aren't the lines:
> 
> >    {
> >      register uint32_t state = (uint32_t)demux->priv;
> >      register int pos = -len;
> 
> and the lines afterwards are dead code because of the "return" you
> added? Shouldn't they be removed?

I added a free_demux_packet, not a return. So I don't really understand
what you mean :-(

Greetings,
Reimar Döffinger




More information about the MPlayer-cvslog mailing list