[MPlayer-cvslog] CVS: main/libmpdemux muxer_lavf.c,1.26,1.27

[Michael Niedermayer]

Hi

On Sun, Mar 12, 2006 at 10:35:58PM +0100, Nico Sabbi wrote:
> Michael Niedermayer wrote:
> 
> >Hi
> >
> >On Sun, Mar 12, 2006 at 08:05:59PM +0100, Nico Sabbi CVS wrote:
> > 
> >
> >>CVS change done by Nico Sabbi CVS
> >>
> >>Update of /cvsroot/mplayer/main/libmpdemux
> >>In directory mail:/var2/tmp/cvs-serv8458
> >>
> >>Modified Files:
> >>	muxer_lavf.c 
> >>Log Message:
> >>in fix_parameters() move assignment of audio bitrate to the proper block 
> >>(the bitrate for video is actually hardcoded to 800000)
> >>   
> >>
> >
> >why? if stream->wf->nAvgBytesPerSec is set in the video case it should be
> >honored too
> >
> >[...]
> > 
> >
> but below, in the block
> 
> else if(stream->type == MUXER_TYPE_VIDEO
> 
> it's unconditionally hardcoded to
> ctx->bit_rate = 800000;

hmm, indeed but then your commit was just cosmetical, or was it supposed
to be a optimization? ;)

anyway passing the actual video bitrate somwhow might be a good idea ...
though maybe wf->nAvgBytesPerSec is not a terribly good way to do it ...


[...]
-- 
Michael