[MPlayer-cvslog] CVS: main subreader.c,1.147,1.148

Ivan Kalvachev ikalvachev at gmail.com
Sat Mar 18 11:46:28 CET 2006

2006/3/18, Jindrich Makovicka <makovick at kmlinux.fjfi.cvut.cz>:
> Ivan Kalvachev CVS wrote:
> > CVS change done by Ivan Kalvachev CVS
> >
> > Update of /cvsroot/mplayer/main
> > In directory mail:/var2/tmp/cvs-serv30786
> >
> > Modified Files:
> >       subreader.c
> > Log Message:
> > if stream is not seekable calling enca would prevent the real parsing of subtitles.
> I don't think it is necessary with the stream_reset calls. Also, the
> format detection would have the same problem otherwise, so either revert
> this or disable the subtitles completely for unseekable streams.

Not really, the detection reads a line and tries to find know pattern.
There is very good chanse that subtitles will be detected in the first
2k (this is the default stream block size).

On the other side enca allocates 256kb buffer and tries to fill it.
This for sure will get out of 2kb range.

Possibe solution:
1. add st->block_size check to my function.
2. increase st->block size for the subtitle stream.
3. decrease enca buffer
4. use cache for subtitles. (another fork())

Anyway I commited this before i sow your reset fix,  you are free to
do as you please.

More information about the MPlayer-cvslog mailing list