[MPlayer-cvslog] CVS: main subreader.c,1.147,1.148

Jindrich Makovicka makovick at kmlinux.fjfi.cvut.cz
Sun Mar 19 19:17:35 CET 2006


Rich Felker wrote:
> BTW please do not cast the return value of malloc. Doing so is
> incorrect and horrible style (it masks bugs).

Fortunately, not in newer gcc versions. You can also use -Wimplicit, if 
missing includes scare you. It's a unnecessary C++ism, but IMO harmless.

> BTW2, 100l to whoever the idiot was who wrote malloc(foo*sizeof(char))
> in the original code...

Gulp. Probably me, but as far as I remember, it was copy&paste from some 
example program :)

-- 
Jindrich Makovicka




More information about the MPlayer-cvslog mailing list