[MPlayer-cvslog] CVS: main/libmpdemux demux_audio.c,1.46,1.47

Reimar Doeffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue Mar 21 08:31:44 CET 2006


Hi,
On Mon, Mar 20, 2006 at 09:06:07PM +0100, Aurelien Jacobs CVS wrote:
> +        uint8_t *p = ptr;
> +        length = p[0] + (p[1] << 8) + (p[2] << 16) + (p[3] << 24);
> +        ptr += 4 + length;
> +
> +        p = ptr;
> +        comment_list_len = p[0] + (p[1] << 8) + (p[2] << 16) + (p[3] << 24);

Could somebody please take the time to add some proper checking here so
that at least it won't crash when length is too big?

Greetings,
Reimar Doeffinger




More information about the MPlayer-cvslog mailing list