[MPlayer-cvslog] CVS: main/libmpdemux muxer_lavf.c,1.25,1.26

[Reimar Döffinger]

Hi,
On Sun, Mar 12, 2006 at 10:49:05PM +0100, Nico Sabbi wrote:
> Michael Niedermayer wrote:
> >On Sun, Mar 12, 2006 at 07:58:11PM +0100, Nico Sabbi CVS wrote:
> >>CVS change done by Nico Sabbi CVS
> >
> >neither of these changes looks correct, REVERSE!
> >
> >either wf&bih are guranteed to be set OR the code should be changed to
> >work without them OR you should print an error / assert(0) whatever
> >this hides the problem instead of fixing it
> >
> 
> ok, in a minute

btw. there is still this rather funny code piece (lines 106 - 111):
muxer_priv_t *priv = muxer->priv;
[...]
if(!muxer || (type != MUXER_TYPE_VIDEO && type != MUXER_TYPE_AUDIO))

Now, what would be the right way to "fix" this? May muxer be NULL here?
Though there is no bog problem in leaving it as is, it's just a bit
weird *g*

Greetings,
Reimar Doeffinger