[MPlayer-cvslog] CVS: main/libvo font_load_ft.c,1.17,1.18

[The Wanderer]

Ivan Kalvachev wrote:

> 2006/3/24, Alban Bedel CVS <syncmail at mplayerhq.hu>:
> 
>> CVS change done by Alban Bedel CVS
>> 
>> Update of /cvsroot/mplayer/main/libvo
>> In directory mail:/var2/tmp/cvs-serv20811/libvo
>> 
>> Modified Files:
>>         font_load_ft.c
>> Log Message:
>> The fix in mp_msg.c avoids a core dump when iconv_open() fails, the other
>> just makes it possible to compile if USE_ICONV is undefined.
>> 
>> Patch by Bjorn Sandell (biorn _At_ chalmers _Dot_ se).
> 
> What the hell? I don't have such patch in my mailbox -dev-eng maillist!

I had it in my tracker. (Yes, I'm still keeping that up, even though I
haven't been sending reminders lately.) It came through -dev-eng on the
23rd, timestamped 10:39 AM; if you don't have it, you may be missing
list mail.

> This patch is useless as iconv requirement in configure is not
> removed, not to say that this may compile but it won't work even in
> unicode only case. I oppose on committing broken stuff.

I'll admit that I was surprised to see it committed, given what little I
remember of iconv discussion in the past, but I don't consider myself
enough of an authority on the subject to speak up.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.